PierMesh
/
direwolf
mirror of https://github.com/wb2osz/direwolf.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue 545 - Saved station location overwritten by Object report from that station.

This commit is contained in:
wb2osz 2024-09-21 19:12:03 +01:00
parent 5d7b10abd9
commit 0734e46134
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mheard.c
View File

@ -406,6 +406,7 @@ void mheard_save_rf (int chan, decode_aprs_t *A, packet_t pp, alevel_t alevel, r
mptr->chan = chan; mptr->chan = chan;
mptr->num_digi_hops = hops; mptr->num_digi_hops = hops;
mptr->last_heard_rf = now; mptr->last_heard_rf = now;
// Why did I do this instead of saving the location for a position report?
mptr->dlat = G_UNKNOWN; mptr->dlat = G_UNKNOWN;
mptr->dlon = G_UNKNOWN; mptr->dlon = G_UNKNOWN;
@ -446,10 +447,17 @@ void mheard_save_rf (int chan, decode_aprs_t *A, packet_t pp, alevel_t alevel, r
} }
} }
// Issue 545. This was not thought out well.
// There was a case where a station sent a position report and the location was stored.
// Later, the same station sent an object report and the stations's location was overwritten
// by the object location. Solution: Save location only if position report.
if (A->g_packet_type == packet_type_position) {
if (A->g_lat != G_UNKNOWN && A->g_lon != G_UNKNOWN) { if (A->g_lat != G_UNKNOWN && A->g_lon != G_UNKNOWN) {
mptr->dlat = A->g_lat; mptr->dlat = A->g_lat;
mptr->dlon = A->g_lon; mptr->dlon = A->g_lon;
} }
}
if (mheard_debug >= 2) { if (mheard_debug >= 2) {
int limit = 10; // normally 30 or 60. more frequent when debugging. int limit = 10; // normally 30 or 60. more frequent when debugging.